0001264: Option for sv_unblockplayers to work only for allies

Notes
(0005844) Dusk (developer) 2013-01-28 14:26	I think this was an oversight and this should've been default behavior..

(0010207) Leonard (developer) 2014-08-15 07:05	'https://bitbucket.org/Torr_Samaho/zandronum-stable/pull-request/66/sv_unblockplayers-now-works-with-different/diff [^]'

(0011104) Torr Samaho (administrator) 2014-12-28 16:08	0001318:0011103

(0011195) Leonard (developer) 2015-01-01 21:36	I'm not sure what should be done about this. Should we create a new dmflag (or zadmflag)? If so how would it behave if both sv_unblockallies and sv_unblockplayers are set?

(0011335) Catastrophe (reporter) 2015-01-08 18:52	sv_unblockplayers 1 (unblocks all) sv_unblockplayers 2 (unblocks team players)

(0011336) Edward-san (developer) 2015-01-08 20:03	I'm with ^. It would make no sense to add sv_unblockallies. What happens if sv_unblockallies were not set and sv_unblockplayers were set? Block the allies and not the enemies? Sounds displeasing.

(0011338) Torr Samaho (administrator) 2015-01-08 21:03 edited on: 2015-01-08 21:04	It's straight forward to reasonably define sv_unblockplayers and sv_unblockallies by just letting them do what their name implies. The former turns of all player-player blocking, the latter just the player-player blocking of allied players. In particular, this means that if sv_unblockplayers is set, the value of sv_unblockallies has no effect. Note that sv_unblockplayers is a dmflag. As a flag it can only have the values true or false. If you want sv_unblockplayers to respect 0, 1 and 2 it has to be removed from the dmflags and converted to an int CVAR.

(0011341) Edward-san (developer) 2015-01-09 01:12	Uh indeed... anyways, since we need a new flag for sv_unblockallies, and since there are flag changes between 1.3 and 2.0, should this code addition be made into 2.0?

(0011343) Dusk (developer) 2015-01-09 16:03	'https://bitbucket.org/Torr_Samaho/zandronum/pull-request/57 [^]'

(0011350) cobalt (updater) 2015-01-10 12:37	Issue addressed by commit 45f2c5e: - added dmflag sv_unblockallies which is like sv_unblockplayers except only unblocks ally players (addreses 1264) Committed by Teemu Piippo [Dusk] on Friday 09 January 2015 05:10:39 Changes in files: docs/zandronum-history.txt \| 1 + src/d_main.cpp \| 1 + src/doomdef.h \| 3 +++ src/p_interaction.cpp \| 11 ++++++++--- src/p_local.h \| 3 +++ src/p_map.cpp \| 23 ++++++++++++++++++----- 6 files changed, 34 insertions(+), 8 deletions(-)

(0011420) StrikerMan780 (reporter) 2015-01-18 03:16	This is working great.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	bluewizard President People Qent Empyre WaTaKiD Combinebobnt
Opponents:	No one explicitly opposes this issue yet.

Issue Community Support

This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.

Supporters:

bluewizard President People Qent Empyre WaTaKiD Combinebobnt

Opponents:

No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2013-01-28 14:00	ZzZombo	New Issue
2013-01-28 14:26	Dusk	Note Added: 0005844
2013-07-22 14:42	Dusk	Relationship added	related to 0001318
2014-06-14 17:27	Watermelon	Status	new => confirmed
2014-08-15 07:05	Leonard	Note Added: 0010207
2014-08-17 18:42	Dusk	Status	confirmed => needs review
2014-12-28 16:08	Torr Samaho	Note Added: 0011104
2014-12-28 16:08	Torr Samaho	Assigned To	=> Torr Samaho
2014-12-28 16:08	Torr Samaho	Status	needs review => feedback
2014-12-28 16:08	Torr Samaho	Assigned To	Torr Samaho =>
2015-01-01 21:36	Leonard	Note Added: 0011195
2015-01-08 15:15	Dusk	Assigned To	=> Dusk
2015-01-08 15:15	Dusk	Status	feedback => assigned
2015-01-08 18:52	Catastrophe	Note Added: 0011335
2015-01-08 20:03	Edward-san	Note Added: 0011336
2015-01-08 21:03	Torr Samaho	Note Added: 0011338
2015-01-08 21:04	Torr Samaho	Note Edited: 0011338	View Revisions
2015-01-08 21:05	Torr Samaho	Note Revision Dropped: 11338: 0006360
2015-01-09 01:12	Edward-san	Note Added: 0011341
2015-01-09 16:03	Dusk	Note Added: 0011343
2015-01-09 16:03	Dusk	Status	assigned => needs review
2015-01-10 11:20	Torr Samaho	Status	needs review => needs testing
2015-01-10 12:36	cobalt	Target Version	=> 2.0
2015-01-10 12:37	cobalt	Note Added: 0011350
2015-01-18 03:16	StrikerMan780	Note Added: 0011420
2015-01-18 10:49	Dusk	Status	needs testing => resolved
2015-01-18 10:49	Dusk	Fixed in Version	=> 2.0
2015-01-18 10:49	Dusk	Resolution	open => fixed
2018-09-30 23:08	Blzut3	Status	resolved => closed