Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001247Zandronum[All Projects] Bugpublic2013-01-12 13:342018-09-30 23:07
ReporterZalewa 
Assigned ToTorr Samaho 
PrioritynormalSeveritycrashReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOSWindowsOS Version7
Product Version1.0 
Target Version2.0Fixed in Version2.0 
Summary0001247: DEHACKED with no trailing new line in a WAD causes game to crash on start
DescriptionIf DEHACKED lump is present in a WAD, and this lump ends with a "Text" patch, and this "Text" patch doesn't end with a trailing new line then the game is almost certain to crash. The crash doesn't occur all the time, but it occurs on most attempts to start the game.

I'm uploading the offending WAD and a patch that fixes the problem. I'm not sure if the change made by the patch is the correct way to fix the issue but the game doesn't crash anymore.

This problem occurs on Zandronum 1.0 and on changeset "3612 (a0f56d2944ca)" from the bitbucket repo (https://bitbucket.org/Torr_Samaho/zandronum/commits/a0f56d2944ca49657ca9e7526fd1d3218f38019c)
Additional InformationI have AMD CPU.
Attached Files? file icon dehacked-offender.wad [^] (5,102 bytes) 2013-01-12 13:34
txt file icon dehacked-lump-patch.txt [^] (403 bytes) 2013-01-12 13:34 [Show Content]

- Relationships
child of 0001490closedTorr Samaho Backport ZDoom 2.5.0 

-  Notes
User avatar (0005738)
Torr Samaho (administrator)
2013-01-12 20:17

 Is GZDoom 323 having the same problem? If so, is the latest ZDoom version also affected?
User avatar (0005741)
Zalewa (developer)
2013-01-12 20:27
edited on: 2013-01-12 20:34

 I managed to crash GZDoom once in several attempts. ZDoom 2.6.1 doesn't want to crash but I may just be lucky. After all, Zandronum doesn't crash always either, but it crashes usually. Running ZDoom in debugger would probably tell us for sure but I don't have that project set up to check it easily.
User avatar (0005749)
Torr Samaho (administrator)
2013-01-13 09:53

 After skimming through ZDoom SVN history I think ZDoom fixed this in revision 2035. Unfortunately their fix is intertwined with other changes to the parser made in earlier revisions, so I can't backport it as is.
User avatar (0011385)
Dusk (developer)
2015-01-15 17:56

 r2035 should be ported into 2.0 by now.
User avatar (0011504)
WaTaKiD (updater)
2015-01-22 20:09

 after testing with 2.0-r150119-2001, issue seems fixed

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2013-01-12 13:34 Zalewa New Issue
2013-01-12 13:34 Zalewa File Added: dehacked-offender.wad
2013-01-12 13:34 Zalewa File Added: dehacked-lump-patch.txt
2013-01-12 13:39 Zalewa Description Updated View Revisions
2013-01-12 13:39 Zalewa Description Updated View Revisions
2013-01-12 13:53 Zalewa Description Updated View Revisions
2013-01-12 14:01 Zalewa OS => Windows
2013-01-12 14:01 Zalewa OS Version => 7
2013-01-12 14:01 Zalewa Additional Information Updated View Revisions
2013-01-12 19:47 Zalewa Product Version => 1.0
2013-01-12 20:17 Torr Samaho Note Added: 0005738
2013-01-12 20:18 Torr Samaho Status new => feedback
2013-01-12 20:27 Zalewa Note Added: 0005741
2013-01-12 20:27 Zalewa Status feedback => new
2013-01-12 20:34 Zalewa Note Edited: 0005741 View Revisions
2013-01-13 09:53 Torr Samaho Note Added: 0005749
2013-01-13 09:55 Torr Samaho Status new => feedback
2015-01-15 17:56 Dusk Note Added: 0011385
2015-01-15 17:56 Dusk Assigned To => Torr Samaho
2015-01-15 17:56 Dusk Status feedback => needs testing
2015-01-15 17:56 Dusk Relationship added child of 0001490
2015-01-15 17:57 Dusk Target Version => 2.0
2015-01-15 17:57 Edward-san Note Added: 0011386
2015-01-15 17:57 Edward-san Status needs testing => needs review
2015-01-15 17:57 Edward-san Status needs review => needs testing
2015-01-15 17:58 Edward-san Note Deleted: 0011386
2015-01-22 20:09 WaTaKiD Note Added: 0011504
2015-01-22 22:35 Arco Status needs testing => resolved
2015-01-22 22:35 Arco Fixed in Version => 2.0
2015-01-22 22:35 Arco Resolution open => fixed
2018-09-30 23:07 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker