MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003186Zandronum[All Projects] Bugpublic2017-07-14 00:202018-09-30 22:33
ReporterNinjamander 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionno change required 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version3.0-beta 
Target VersionFixed in Version 
Summary0003186: Broken Revival kit in RGA2 in survival/coop
DescriptionAfter testing Real Gun advance (rga2ref_core.wad , rga2ref_code_140.wad , rga2ref_mon_140.wad and rga2ref_blade_140.wad)

I notice the revival kit work perfectly in zandronum 2.1.2 but will result in player dying in 3.x. I suspect is been like this for a while now
Steps To ReproducePlayer A get last stand perk
Player B get last stand pro perk
Player A get shot down and need to get revived
Player B select the revival kit and (shoot) the player with it at melee range

result per version:
2.1.2 Player A get revived and continue on his rampage
3.x Player A either get revived very briefly then die right after or simply die
Additional InformationI do not know what version of 3.x broke this sadly
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-07-14 00:20NinjamanderNew Issue
2017-07-14 06:00Torr SamahoNote Added: 0018022
2017-07-14 06:01Torr SamahoStatusnew => feedback
2017-07-14 13:09KorshunNote Added: 0018023
2017-07-14 13:10KorshunNote Edited: 0018023bug_revision_view_page.php?bugnote_id=18023#r10764
2017-07-14 13:11KorshunNote Edited: 0018023bug_revision_view_page.php?bugnote_id=18023#r10765
2017-07-14 19:12jdagenetNote Added: 0018028
2017-07-14 21:16KorshunNote Added: 0018029
2017-07-14 21:17KorshunNote Edited: 0018029bug_revision_view_page.php?bugnote_id=18029#r10769
2017-07-14 21:39jdagenetNote Added: 0018030
2017-07-14 21:41jdagenetNote Edited: 0018030bug_revision_view_page.php?bugnote_id=18030#r10771
2017-07-14 21:58KorshunNote Added: 0018032
2017-07-14 22:01KorshunNote Edited: 0018032bug_revision_view_page.php?bugnote_id=18032#r10773
2017-07-15 04:02NinjamanderNote Added: 0018034
2017-07-15 04:02NinjamanderStatusfeedback => new
2017-07-15 08:42DuskStatusnew => resolved
2017-07-15 08:42DuskResolutionopen => no change required
2018-09-30 22:33Blzut3Statusresolved => closed

Notes
(0018022)
Torr Samaho   
2017-07-14 06:00   
Can somebody condense this to a minimal example?
(0018023)
Korshun   
2017-07-14 13:09   
(edited on: 2017-07-14 13:11)
RGA2 code is way too overcomplicated to reliably reduce it to a minimal example wad.

This bug is present in ALL 3.0 versions (both the latest and 150819-2351), but not in 2.1.2. It is also present on Linux, as it happens on TSPG.

This bug makes the reviving player seem to apply the revive script on himself (judging by the screen flash) instead of on the intended player.

An easy way to test this bug is to do the following:
1. run a server
2. connect and join as "Juggernaut" class
3. connect and join in another instance of Zandronum as "Medic" class
4. as Juggernaut, throw two greandes under your feet
5. as Medic, try to revive the Juggernaut
(0018028)
jdagenet   
2017-07-14 19:12   
The issue seems to be the morphing flag "MRF_LOSEACTUALWEAPON", though I'm not sure if the flag is broken or if the mod wasn't built with that flag in mind.

Torr, was that flag present in 2.1.2?
(0018029)
Korshun   
2017-07-14 21:16   
(edited on: 2017-07-14 21:17)
This bug is caused by script 625 getting called immediately after successful revive. It is not called after reviving in 2.1.2.

It is also most likely unrelated to morph flags.
(0018030)
jdagenet   
2017-07-14 21:39   
(edited on: 2017-07-14 21:41)
It is related to the morphing flags. If you don't pass any flags when the player is sent to last stand then he doesn't die if someone tries to revive him.
(0018032)
Korshun   
2017-07-14 21:58   
(edited on: 2017-07-14 22:01)
Really? That fixes the issue! Why did't you say so right away? I am releasing a patch for RGA2.
(0018034)
Ninjamander   
2017-07-15 04:02   
Guess they is no bug after all, on the bright side, this ticket was not totally pointless it seem!