MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003176Zandronum[All Projects] Bugpublic2017-07-01 19:382018-09-30 21:42
ReporterKaminsky 
Assigned ToTorr Samaho 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0003176: Ignored players are somehow unignored after map changes
DescriptionA couple of people have told me that they've ignored certain players in the game, but after a map changes, it seems they're unignored because you can read their chat messages again. This happens even when the ignore hasn't expired yet.

I hosted my own server with another player, and I can confirm that this issue occurs in v3.0-alpha 170625-1906, but not reproducible in v2.1.2.
Steps To Reproduce1. Host a server.
2. Join the server with one or more players (or bots).
3. Ignore a player for an indefinite period of time.
4. Change the map (either by beating the level or using the "changemap" command).
5. Upon map change, previously ignored players are suddenly unignored and you can read their chat messages.
Additional Information
TagsNo tags attached.
Relationships
Attached Files? pthink_spam.cld (384,566) 2017-07-02 22:01
https://zandronum.com/tracker/file_download.php?file_id=2139&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-07-01 19:38KaminskyNew Issue
2017-07-02 01:04Ru5tK1ngNote Added: 0017960
2017-07-02 20:01Torr SamahoNote Added: 0017965
2017-07-02 20:01Torr SamahoAssigned To => Torr Samaho
2017-07-02 20:01Torr SamahoStatusnew => needs testing
2017-07-02 20:33KaminskyNote Added: 0017967
2017-07-02 20:35KaminskyNote Edited: 0017967bug_revision_view_page.php?rev_id=10747
2017-07-02 20:35KaminskyNote Edited: 0017967bug_revision_view_page.php?rev_id=10748
2017-07-02 20:35KaminskyNote Edited: 0017967bug_revision_view_page.php?rev_id=10749
2017-07-02 20:59Ru5tK1ngNote Added: 0017968
2017-07-02 21:06Torr SamahoNote Added: 0017969
2017-07-02 21:29KaminskyNote Deleted: 0017967
2017-07-02 22:01Ru5tK1ngFile Added: pthink_spam.cld
2017-07-02 22:02Ru5tK1ngNote Added: 0017970
2017-07-08 11:41Torr SamahoNote Added: 0017987
2017-07-08 11:41Torr SamahoTarget Version => 3.0
2017-07-09 16:08Ru5tK1ngNote Added: 0017991
2017-07-09 23:52Ru5tK1ngNote Added: 0017999
2017-07-09 23:52Ru5tK1ngStatusneeds testing => resolved
2017-07-09 23:52Ru5tK1ngResolutionopen => fixed
2017-07-09 23:52Ru5tK1ngFixed in Version => 3.0
2018-09-30 21:42Blzut3Statusresolved => closed

Notes
(0017960)
Ru5tK1ng   
2017-07-02 01:04   
Seems to be a result of this:

'https://bitbucket.org/Torr_Samaho/zandronum/commits/f0ba466ed3ff4b0140c1eda3c7ed69f8bf955f64 [^]'
(0017965)
Torr Samaho   
2017-07-02 20:01   
Can you check if'https://bitbucket.org/zandronum/zandronum-sandbox/commits/c2032e0cb1b8dd1170f6c4a854457e7c142589a1 [^]' fixes the issue without reintroducing the "no body for player" warnings reported in 0003132?
(0017968)
Ru5tK1ng   
2017-07-02 20:59   
While that does fix the ignore issue, I was able to reproduce the P_PlayerThink error spam with 3 clients and 40 bots as described in 3132
(0017969)
Torr Samaho   
2017-07-02 21:06   
Thanks for checking! Can you make a client side demo of the error?
(0017970)
Ru5tK1ng   
2017-07-02 22:02   
I attached the demo to the ticket. Play it with the unnamedtest.wad from 3127.
(0017987)
Torr Samaho   
2017-07-08 11:41   
Thanks for the demo! Can you check if 'https://bitbucket.org/zandronum/zandronum-sandbox/commits/a739ef6c853358d791d1d413df52bdade2b0e963 [^]' fixes the issue?
(0017991)
Ru5tK1ng   
2017-07-09 16:08   
I couldn't reproduce the PlayerThink spam with those changes and ignore was still working fine.
(0017999)
Ru5tK1ng   
2017-07-09 23:52   
<Kaminsky> Also, players that I were ignored were still ignored even after the level changes, as expected.
<Kaminsky> I didn't get and P_PlayerThink spam caused by the latter ticket either.