MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002846Zandronum[All Projects] Bugpublic2016-10-01 19:062018-09-30 21:46
ReporterAtomicLugia 
Assigned To 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0002846: Railgun kills ignores custom obituaries
DescriptionI'm working on a lightning gun and it has the obituary "%o was electroduced by %k's lightning gun.". But if I kill a plyer/bot with this weapon, it prints out "%o was railed by %k.".
Steps To Reproduce - Create a custom weapon with uses A_RailAttack.
 - Create a custom obituary for this weapon.
 - Start Zandronum with it.
 - Play a deathmatch with a bot.
 - Get the weapon with IDKFA or Give.
 - Kill the bot.
 - Look at the messages.

OR

 - Start Zandronum with the included WAD.
 - Play a deathmatch with a bot.
 - Get the weapon with IDKFA or Give.
 - Kill the bot.
 - Look at the messages.
Additional InformationThe weapon also spams the "Impressive!" medal, because it uses a Railgun attack. An option to prevent this would be nice, too. xD
TagsNo tags attached.
Relationships
Attached Files? LightningGun.wad (83,932) 2016-10-01 19:06
https://zandronum.com/tracker/file_download.php?file_id=1891&type=bug
? LightningGun212.wad (83,422) 2016-11-27 16:37
https://zandronum.com/tracker/file_download.php?file_id=1973&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-10-01 19:06AtomicLugiaNew Issue
2016-10-01 19:06AtomicLugiaFile Added: LightningGun.wad
2016-10-02 04:20Ru5tK1ngNote Added: 0015721
2016-10-02 09:17IvanNote Added: 0015723
2016-10-02 09:39AtomicLugiaNote Added: 0015724
2016-10-02 09:50Edward-sanNote Added: 0015725
2016-10-02 09:50Edward-sanStatusnew => feedback
2016-10-06 16:38AtomicLugiaNote Added: 0015776
2016-10-06 16:38AtomicLugiaStatusfeedback => new
2016-10-06 17:11Edward-sanStatusnew => acknowledged
2016-10-06 17:11Edward-sanResolutionopen => waiting for zdoom
2016-11-27 16:37Torr SamahoFile Added: LightningGun212.wad
2016-11-27 16:38Torr SamahoNote Added: 0016358
2016-11-27 16:38Torr SamahoTarget Version => 3.0
2017-01-28 20:56Ru5tK1ngNote Added: 0016710
2017-02-08 19:47Ru5tK1ngNote Added: 0016827
2017-02-08 19:47Ru5tK1ngNote Edited: 0016827bug_revision_view_page.php?bugnote_id=16827#r10153
2017-02-08 19:48Ru5tK1ngNote Edited: 0016827bug_revision_view_page.php?bugnote_id=16827#r10154
2017-02-08 20:11Ru5tK1ngNote Added: 0016828
2017-02-08 20:28Ru5tK1ngNote Deleted: 0016828
2017-02-08 20:45Edward-sanNote Added: 0016829
2017-02-08 22:08Ru5tK1ngNote Added: 0016830
2017-02-11 12:50Torr SamahoNote Added: 0016834
2017-02-11 12:50Torr SamahoStatusacknowledged => feedback
2017-02-11 19:10Ru5tK1ngNote Added: 0016838
2017-02-11 20:53Edward-sanNote Added: 0016840
2017-02-12 00:48Ru5tK1ngNote Added: 0016841
2017-02-12 00:51Ru5tK1ngNote Deleted: 0016841
2017-02-12 21:41Ru5tK1ngNote Added: 0016855
2017-02-12 21:42Ru5tK1ngStatusfeedback => needs review
2017-03-05 19:41Ru5tK1ngNote Added: 0016942
2017-03-05 19:41Ru5tK1ngStatusneeds review => needs testing
2017-03-05 19:41Ru5tK1ngResolutionwaiting for zdoom => open
2017-04-19 23:08CombinebobntNote Added: 0017232
2017-04-20 00:56Ru5tK1ngNote Added: 0017237
2017-04-20 00:56Ru5tK1ngStatusneeds testing => resolved
2017-04-20 00:56Ru5tK1ngResolutionopen => fixed
2017-04-20 00:56Ru5tK1ngFixed in Version => 3.0
2018-09-30 21:46Blzut3Statusresolved => closed

Notes
(0015721)
Ru5tK1ng   
2016-10-02 04:20   
I took a look at the decorate and it seems fine. Given the fact the obituary is ignored in GZdoom 1.8.6 and Zdoom 2.8, this should be reported to ZDoom.
(0015723)
Ivan   
2016-10-02 09:17   
Turn off medals to disable that medal spam thing.
(0015724)
AtomicLugia   
2016-10-02 09:39   
It's also ignored in ZDoom 2.8.1, GZDoom 2.2 and GZDoom 2.3pre.
(0015725)
Edward-san   
2016-10-02 09:50   
Then please report it in zdoom forum.
(0015776)
AtomicLugia   
2016-10-06 16:38   
I reported it in the ZDoom forums.

'http://forum.zdoom.org/viewtopic.php?f=2&t=53731 [^]'
(0016358)
Torr Samaho   
2016-11-27 16:38   
I added Zandronum 2.1.2 compatible version of the example. With it, it works in 2.1.2 but not in 3.0. So this is a regression.
(0016710)
Ru5tK1ng   
2017-01-28 20:56   
The ClientObituary code is the same between 2.1.2 and 3.0. I wasn't able to find the cause of the regression, but commenting out:'https://bitbucket.org/Torr_Samaho/zandronum/src/0c977c782fb6d412681bd05e7539b4159d832138/src/p_interaction.cpp?at=default&fileviewer=file-view-default#p_interaction.cpp-341 [^]'

seemed to fix the railgun obituary. But I don't think that's the right way to go about it.
(0016827)
Ru5tK1ng   
2017-02-08 19:47   
(edited on: 2017-02-08 19:48)
Did a bit of testing and apparently the obituary behavior broke between zdoom 2.5 & 2.6. Hopefully this narrows it down enough to findthe cause.
(0016829)
Edward-san   
2017-02-08 20:45   
I already found the cause, see this.
(0016830)
Ru5tK1ng   
2017-02-08 22:08   
This seemed to fix the issue.
(0016834)
Torr Samaho   
2017-02-11 12:50   
The patch does not seem to work for me. I start the game with

zandronum -file LightningGun212.wad -deathmatch +map map01

add a bot and get the wrong obituary. In 2.1.2, this works fine. Did you test your patch offline or online?
(0016838)
Ru5tK1ng   
2017-02-11 19:10   
Hmm, I tested online with a bot and the obituary shows up fine. But now I caught that it doesn't offline. I'll have to take another shot.
(0016840)
Edward-san   
2017-02-11 20:53   
Added a ticket in the zdoom tracker for making this bug more visible:'https://mantis.zdoom.org/view.php?id=244 [^]'
(0016855)
Ru5tK1ng   
2017-02-12 21:41   
Following Torr's suggestion, this seemed to fix the obituary offline and it works online. If there is no specified obituary on a weapon using railattack, the default OB_Railgun message gets used successfully.
(0016942)
Ru5tK1ng   
2017-03-05 19:41   
Patch was added, needs testing.
(0017232)
Combinebobnt   
2017-04-19 23:08   
r170416-0710

tested LightningGun212.wad offline/online in dm/tlms. the obiturary worked.
(0017237)
Ru5tK1ng   
2017-04-20 00:56   
Thanks for testing my patch.