MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002672Zandronum[All Projects] Bugpublic2016-03-10 22:592018-09-30 21:47
Reporterthrowaway 
Assigned ToTorr Samaho 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0002672: 'turbo' cheat kicks in the SR50 detection in single player
DescriptionThe 'turbo' cheat isn't factored in when calculating SR40 speed. This leads to your turning being locked when strafing with it.
Steps To Reproduce1. 'turbo 255'
2. Strafe sideways.
3. Try to turn while strafing.
Additional InformationWhy the SR50 thing triggers in non-competitive game modes, or in single player at all, is beyond me.
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-03-10 22:59throwawayNew Issue
2016-03-11 04:33AlienOverlordNote Added: 0014572
2016-03-11 04:33AlienOverlordNote Edited: 0014572bug_revision_view_page.php?bugnote_id=14572#r8831
2016-03-11 21:59throwawayNote Added: 0014573
2016-03-11 22:01throwawayNote Edited: 0014573bug_revision_view_page.php?bugnote_id=14573#r8833
2016-03-12 00:00throwawayNote Added: 0014574
2016-03-25 22:12throwawayNote Added: 0014607
2016-11-27 16:48Torr SamahoTarget Version => 3.0
2016-11-29 20:27Torr SamahoNote Added: 0016376
2016-11-29 20:27Torr SamahoAssigned To => Torr Samaho
2016-11-29 20:27Torr SamahoStatusnew => needs testing
2017-02-06 23:49WaTaKiDNote Added: 0016804
2017-02-06 23:50WaTaKiDStatusneeds testing => assigned
2017-02-07 07:02Torr SamahoNote Added: 0016808
2017-02-07 07:03Torr SamahoStatusassigned => feedback
2017-02-07 09:06WaTaKiDNote Added: 0016809
2017-03-05 18:41Torr SamahoNote Added: 0016940
2017-03-05 18:42Torr SamahoStatusfeedback => needs testing
2017-04-19 23:04CombinebobntNote Added: 0017231
2017-04-20 00:56Ru5tK1ngStatusneeds testing => resolved
2017-04-20 00:56Ru5tK1ngResolutionopen => fixed
2017-04-20 00:56Ru5tK1ngFixed in Version => 3.0
2018-09-30 21:47Blzut3Statusresolved => closed

Notes
(0014572)
AlienOverlord   
2016-03-11 04:33   
Just saying SR50 detection was made for a non-competitive game mode. (Coop, jumpmaze)

Also the real bug here is that turbo 255 isn't cut to 100 in singleplayer, IMO.
(0014573)
throwaway   
2016-03-11 21:59   
(edited on: 2016-03-11 22:01)
"Also the real bug here is that turbo 255 isn't cut to 100 in singleplayer, IMO."

What? Why the hell would you do that, and how the hell is something that's been around since vanilla Doom as a *feature*... a *bug*?

Also SR50 while turning was possible in vanilla Doom, by taking advantage of joystick strafing inputs. Granted, you needed a custom driver for that, but considering there were custom drivers to cut out vertical mouse movement, it's not that far off.
(0014574)
throwaway   
2016-03-12 00:00   
How about this behaviour gets moved to a CVar? Say, sv_sr50lock? It really should not be on by default - I can't imagine it behaves well with low friction floors either.
(0014607)
throwaway   
2016-03-25 22:12   
Update on this: low friction floors don't affect the lock; it seems to goes off player input. So the fix would simply be to have turbo apply after the SR50 lock is checked.

Any turbo value above 102 will trip the SR50 lock.
(0016376)
Torr Samaho   
2016-11-29 20:27   
Can you check if this fixes the issue?
(0016804)
WaTaKiD   
2017-02-06 23:49   
this was fixed, atleast in singleplayer, with: 'https://bitbucket.org/Torr_Samaho/zandronum/commits/da07f3777ca9d6257b0aecdaf074d9eed3259fe5 [^]'

however online your view is no longer locked in place with turbo 103+ while sr40ing
(0016808)
Torr Samaho   
2017-02-07 07:02   
Quote from WaTaKiD

however online your view is no longer locked in place with turbo 103+ while sr40ing

Can you elaborate? The client shouldn't be able to activate turbo and if the server enables turbo, then there should be no view lock while SR40.
(0016809)
WaTaKiD   
2017-02-07 09:06   
well i did have sv_cheats enabled online, but yea i guess i wasnt entirely clear

your player and your real angle are locked in that direction when you sr40 with turbo 103+

however your view can still be turned around, atleast on your end, as in, start to sr40 and then turn your mouse and fire the plasma gun, you will notice that you could be holding W+D and end up running backwards and your plasma balls are not going where your aiming
(0016940)
Torr Samaho   
2017-03-05 18:41   
The problem is that the turbo value is not synced between client and server. I changed the server to not enforce the SR50 turn lock anymore if sv_cheats is true. This should fix the issue.
(0017231)
Combinebobnt   
2017-04-19 23:04   
r170416-0710

Intial Singleplayer testing instructions worked fine. Could turn my mouse freely sr40 with turbo 103 and 255

Worked online with sv_Cheats 1 too

Setting turbo >100 online with sv_Cheats 0 didn't do anything and I couldn't set turbo, but seeing how that isn't the issue here; looks like the ticket's issue is fixed.